Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added enum_is #257

Merged
merged 4 commits into from
Jun 18, 2023
Merged

Added enum_is #257

merged 4 commits into from
Jun 18, 2023

Conversation

MendyBerger
Copy link
Contributor

Resolves #252

Peternator7
Peternator7 requested changes Mar 12, 2023
View reviewed changes
Copy link
Owner

@Peternator7 Peternator7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Just a couple of hopefully minor tweaks

strum_macros/Cargo.toml Outdated Show resolved Hide resolved
strum_macros/src/macros/enum_is.rs Outdated Show resolved Hide resolved
strum_macros/src/macros/enum_is.rs Outdated Show resolved Hide resolved
@MendyBerger
Copy link
Contributor Author

@Peternator7 I resolved all your comments

@Peternator7 Peternator7 merged commit 85e2c16 into Peternator7:master Jun 18, 2023
@Peternator7
Copy link
Owner

Just release 0.25.0 which has this upgrade! Thanks for putting in the work on this new feature. It will provide a nice convenience for users.

@Peternator7 Peternator7 mentioned this pull request Mar 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peternator7 Peternator7 Peternator7 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is_* methods
2 participants
@MendyBerger @Peternator7